search

sjsakib / cfviz

Visualizes user data from codeforces.com using the official API
http://cfviz.netlify.com
1.12k stars 71 forks source link

solved multiple counting problem issue #28 #29

Closed maskmanlucifer closed 3 years ago

maskmanlucifer commented 3 years ago

sakib please review changes.

sjsakib commented 3 years ago

Please fix the code formatting (spacing, newlines). Try to follow the existing style

maskmanlucifer commented 3 years ago

Okk i am reformatting.

maskmanlucifer commented 3 years ago

Done with reformatting.

maskmanlucifer commented 3 years ago

These changes are for single user data. I tested by submitting div 1 and div 2 common problems, results were quite accurate. Applying same algorithm on compare page is little bit complicated, i can work on that too if you wish. But i hope for now this single page will work fine with these code changes.

sjsakib commented 3 years ago

Sorry for the late response, somehow missed the update. Please format your code with prettier, otherwise, it is hard to tell exactly what changes you made.

maskmanlucifer commented 3 years ago

I am forking repo again and creating a new PR. I think you formated code and there will be a lot of conflcts if i will create a PR with old commits.