search

sjshuck / hs-pcre2

Complete Haskell binding to PCRE2
Apache License 2.0
12 stars 2 forks source link

Support text-2.0 #22

Closed sjshuck closed 2 years ago

sjshuck commented 2 years ago

UTF-8 in text has landed. https://hackage.haskell.org/package/text-2.0/changelog

EDIT: Current list of blockers:

tchoutri commented 2 years ago

@sjshuck I'd like to help with the migration! Anything I could do to help or do you wish to handle this yourself?

sjshuck commented 2 years ago

@tchoutri Absolutely, help welcome! I haven't used Github to track work before; only used Jira and Gitlab. I'll make a task list in the first comment of all the known blockers. ("You cannot create task list items within...issues with linked pull requests" isn't very encouraging...)

tchoutri commented 2 years ago

@sjshuck Wonderful. :) I have a personal stake in this with Flora, so please don't hesitate to share the burden!

sjshuck commented 2 years ago

@tchoutri Created a little list of open issues, see above. I'd like to use text-2 as a feature branch. Feel free to open PRs against it. Thanks!

sjshuck commented 2 years ago

Going to close this but leave #26 open. It's a small regression. I want this in Stackage Nightly ~just like text-2.0 is~. EDIT: text-2.0 isn't in Nightly and I don't know when that's going to happen. But regardless, we're ready for it.

andreasabel commented 2 years ago

Requirement text >= 2 broke Stackage nightly. See:

tchoutri commented 2 years ago

@sjshuck Hi! Now that text-2.0 is shipped with GHC 9.4, do you wish to enable the support? :)

sjshuck commented 2 years ago

@tchoutri Version 2.2+ already supports text-2.0. The only place it isn't enabled is Stackage, where pcre2 is pinned to <2.2, because GHC 9.4 isn't in either LTS or nightly yet. If you want to try to build pcre2 and manage dependencies yourself, this file will help you. If not, wait until text-2.0 is included in Stackage.