search

sjshuck / hs-pcre2

Complete Haskell binding to PCRE2
Apache License 2.0
12 stars 2 forks source link

add CI #6

Closed amesgen closed 3 years ago

amesgen commented 3 years ago
sjshuck commented 3 years ago

Wow, this will be really helpful. Thanks!

I can't really spend time on actual code or PRs until tomorrow night, but I'll definitely review this line by line.

amesgen commented 3 years ago

JFYI you can see the CI run for this PR in my fork: https://github.com/amesgen/hs-pcre2/actions/runs/413246272

amesgen commented 3 years ago

I just noticed that caching is missing, will add in a moment.

sjshuck commented 3 years ago

This is all great. The only reservation I have is that building benchmarks is at 7 minutes the significant majority of CI time. Personally I think the time saved would be a bigger benefit. I could be convinced otherwise though.

amesgen commented 3 years ago

The only reservation I have is that building benchmarks is at 7 minutes the significant majority of CI time.

Yeah, caching should fix that for the most part. I could not get caching to work with stack on macOS (see here), so I just disabled benchmark building for stack entirely instead of using caching. ~See here for the now much faster CI run.~ Caches dont work across branches (see here for the exact conditions when caches are accessible), so see here instead with prepopulated caches.

amesgen commented 3 years ago

Put differently:

sjshuck commented 3 years ago

Really appreciate the time you put into this and answering my questions, as well as your knowledge of cabal - mine is lacking.