search

sjspielman / dragon

Deep time Redox Analysis of the Geobiology Ontology Network
https://sjspielman.shinyapps.io/dragon/
Other
2 stars 1 forks source link

Test suite broke when using igraph 1.2.11 #46

Closed vtraag closed 2 years ago

vtraag commented 2 years ago

In the latest release of igraph, version 1.2.11, the test suite broke due to a change in the cluster_louvain function which now has a stochastic implementation (details in PR https://github.com/igraph/igraph/pull/1696). Hence, the modularity is no longer necessarily exactly 0.4432351, but some value that depends on the random number generator. In order to get reproducible results, so that the test suite doesn't fail, you should seed the RNG prior to running cluster_louvain using set.seed.

szhorvat commented 2 years ago

This should refer only to version 1.3.0, no? I believe 1.2.11 still uses the deterministic implementation.

sjspielman commented 2 years ago

Thanks for catching this! On the way to a fix.

sjspielman commented 2 years ago

Fixed.