search

sjsrey / pysalnarsc17

PySAL Workshop at NARSC17
0 stars 3 forks source link

folium example is broken in 09_geovisualization #4

Open sjsrey opened 7 years ago

sjsrey commented 7 years ago

screenshot from 2017-10-26 19-55-22

ljwolf commented 7 years ago

sorry, I'd forked but didn't get notified of this (I think) because I forked after it was filed.

ljwolf commented 7 years ago

I see you're allowing geopandas in the dependencies!

The modification I want to merge to the folium notebook will strip all the discussion of geojson & plotting from file in favor of plotting straight from the geopandas dataframe:

fm.choropleth_map(dataframe, key='FIPS', attribute='HR90')

I'll ship those here, too, when the folium mapping gets done.

Do you want to try to get a release before NARSC to resolve these things & the chisqprob issue?

sjsrey commented 7 years ago

In theory, yes on the release, but we need to ship the materials for the workshop by Friday COB. So if it is too rushed, we can just wait and drop the folium component for this workshop.

ljwolf commented 7 years ago

OK. Well, I've got fixes in for the scipy breakage pysal/#993 and the folium fix pysal/#995 now. The updated notebook is shorter & just shows the plotting options.

I think the old one was exactly the file I turned in for a group term assignment.