sjstein / R8DIUM

A discord bot to manage individual run8 users
GNU General Public License v3.0
2 stars 0 forks source link

extended discord user scope to entire guild #101

Closed sjstein closed 7 months ago

sjstein commented 7 months ago

Did a bit more than just wide the scope - cleaned up a lot of inconsistencies in str/int handling which I got away with since Python is so forgiving on typing.

This will close issue #100 - bot users will now be able to "see" users outside of the current channel scope

sjstein commented 7 months ago

@Garrisonsan - I'm trying to be a bit more thorough with the master branch and reviewing. I've put you in as a reviewer for this merge as the changes were pretty broad.

This (minor update - no new version name) will allow admins/assistants the ability to access the user list for the entire server ("guild") from any channel. This will allow our yardmaster access to the /show_user, /ban_user, etc. from within the yardmaster chat where the general userbase does not have access.

I also cleaned up a bit of cruft that had found its way in as I was dealing with the <@ > tags and how to handle the discord ID.

I did some pretty thorough testing this morning. Adding, removing, banning, unbanning, automated unbans, reissuing passwords, so I feel like this is a solid build.

That being said, I would like your acceptance before the merge to the master branch is complete. Feel free to either trust my work, or (probably more prudent) install on High Green and run it through a quick check.

If you find something, of course report it. If it seems good, you can approve the merge and I will incorporate these changes into the master branch.