rewrite the whole project thoroughly

sjtug / mirror-docker

Dockerfile for SJTUG mirror

https://mirrors.sjtug.sjtu.edu.cn

GNU Affero General Public License v3.0

31 stars 6 forks source link

Closed lv-zheng closed 8 years ago

lv-zheng commented 8 years ago

Major change description:

Remove jekyll and git from container.
Remove manage.sh, use CMD to directly invoke tunasync and nginx
Split the Dockerfile into two. One for tunasync, the other for nginx
Host server is responsible to prepare (build) the static pages. The static pages are stored in docker volumes.
Change Dockerfile into style recommended by the official doc.

Related issue #10

The diff's are such a mess that don't view the commits. View the final code in dev branch instead.

Endle commented 8 years ago

Shall we put jekyll into another docker? I don't want to install lots of dependencies on the host.

我赞同这一点我已经写了它的补丁： https://github.com/sjtug/mirror-docker/tree/jekyll 但还有调整的空间（有必要纳入 docker-compose 吗？）

lv-zheng commented 8 years ago

@Endle 这个patch有一些细节，让我强迫症又犯了…… 那个selinux是什么情况？

我也赞同为jekyll开一个docker的想法。但是时间紧急，今晚我们先想办法让mirror上线，然后再撸出一个jekyll image来。这个image应该不是daemon形式的，是只run一次。

Endle commented 8 years ago

@Endle 你测试过这个patch吗？

刚才装好了 compose 后测试了一下，可用

我也赞同为jekyll开一个docker的想法。但是时间紧急，今晚我们先想办法让mirror上线，然后再撸出一个jekyll image来。这个image应该不是daemon形式的，是只run一次。

是的，只运行一次。所以我觉得不应该写到 compose 里。编译好的jekyll 会被写入到host的 /home/mirror-web/_site ，然后用 compose 的时候共享给 image

Endle commented 8 years ago

那个selinux是什么情况？

在我的电脑上，如果不打开 Z 的选项，每一次读写都会被 SELinux 阻止服务器上默认打开了 SELinux 吗？

lv-zheng commented 8 years ago

jekyll_lvzheng分支做了点小修改。你觉得可以的话merge一下。

htfy96 commented 8 years ago

Merged.