sjy1203 / GAMENet

GAMENet : Graph Augmented MEmory Networks for Recommending Medication Combination
MIT License
128 stars 43 forks source link

about reproduce the performance #7

Open yuanyuansiyuan opened 4 years ago

yuanyuansiyuan commented 4 years ago

i want to reproduce LEAP and GAMENet, my scripts: %run train_Leap.py %run train_Leap.py --resume_path final.model --eval

%run train_GAMENet.py --model_name GAMENet-ddi --ddi %run train_GAMENet.py --model_name GAMENet-ddi --ddi --resume_path final.model --eval

i choose final.model to do the test predict. Here is my performances:

They are not same as your paper, but have the similar trend, is it normal or have some problems?

Wait for your responses, Thank you!

sjy1203 commented 4 years ago

Thanks for pointing out the problem! This problem is caused by the mismatch between the training data in the Github repository and the training data in our paper.

Way to fix this problem.

If you re-generate the training data using EDA.ipynb, it will provide you with the same data in our paper.

Why higher performance?

The data in the GitHub repository may also be generated by uncommenting a line in EDA.ipynb:

#med_pd = filter_first24hour_med(med_pd)

It means that the medications for a visit are collected beyond 1 day. Thus, the performance may be improved due to more data provided for a patient. But as we have claimed in our paper, the first 24-hour is often the most critical time for patients to obtain correct treatment quickly. However, it depends on you to choose which version of data in your work.

varunuiuc commented 2 years ago

I tried running EDA.ipynb but getting this error 'ndc_rxnorm_file' is not defined. Upon further investigation I figured out there is a mismatch in file name. Please note that.