search

sk- / git-lint

improving source code one step at a time
Apache License 2.0
236 stars 78 forks source link

Fix cached results when program or args change #100

Closed kalkin closed 5 years ago

kalkin commented 6 years ago

When arguments in .gitlintrc change git-lint still serves the old cached results. This commit changes it.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 1ceec2dae2ab94129cff1c47b32b5732be4ccbc2 on kalkin:imporve-cache into on sk-:master.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling e9d56976a0bc9985b1347aedc083add4a8eacddc on kalkin:imporve-cache into on sk-:master.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling e9d56976a0bc9985b1347aedc083add4a8eacddc on kalkin:imporve-cache into on sk-:master.

sk- commented 6 years ago

This change would be much simpler if we instead check the time in which the cached results were generated and the last modification timestamp of the configuration file.

kalkin commented 6 years ago

This change would be much simpler if we instead check the time in which the cached results were generated and the last modification timestamp of the configuration file.

Yes but then you would have to run all linters for the same file and not only the linter whose configuration changed. If you still prefer just to check the timestamp, i will adjust the commit.

kalkin commented 5 years ago

Closing because I replaced git-lint with custom written software and author isn't interested in this PR.