search

sk- / git-lint

improving source code one step at a time
Apache License 2.0
236 stars 78 forks source link

New option --no-color to disable colored output #127

Closed siebert closed 5 years ago

siebert commented 6 years ago

New option --no-color to disable color. Useful for build system logs and consoles without color support.

siebert commented 6 years ago

Thanks for the prompt review. I thought the reason for this change is obvious, especially as it is already on the list of TODOS... I want to use git-lint in a shell job on Jenkins and the color codes are rather distracting in the output, so I want the option to disable them.

Regarding the restructuring of the output formatters, I'm not sure if that additional effort is something I'd like to make for this change. Would you consider to merge my patch without it? Would it be ok to define the new classes within init.py or must they reside in separate modules?