search

sk22 / megalodon

Pink modification of the official Mastodon for Android app
https://sk22.github.io/megalodon
GNU General Public License v3.0
550 stars 33 forks source link

Don't display if user is blocked by a user #526

Closed msparkles closed 1 year ago

msparkles commented 1 year ago

The corresponding API endpoints have been (supposedly) removed as per this issue.

This is possibly very low priority as it shouldn't affect usage, however should be a good cleanup task for any contributors c:

sk22 commented 1 year ago

oh uh i didn't even know megalodon supports this ^^' (i suppose the functionality comes from mastodon for android?)

sk22 commented 1 year ago

okay, apparently, there's no such api endpoint anyway - it's just a field called "blocked_by" that will always have "false" as a value, so i don't think i need to change anything on this end

msparkles commented 1 year ago

Ah, that's convenient.

Well the functionality that we've noticed was the fact that the follow button is greyed out if blocked_by is true, we assumed it was extra support for akkoma because we didn't notice such functionality on mastodon.

So is the reasoning to remove Akkoma's support for it, we'd also like to think such functionality isn't really worthy for any clients? Again, no rush to remove it or anything, just worth considering removing it.

msparkles commented 1 year ago

Mastodon might support it in the future, iunno, but like, it's very unnecessary information to show to the end user that you're blocked :/

sk22 commented 1 year ago

i just tried it and mastodon (or glitch, at least) does seem to support it (and turns out mastodon for android supports it too). the web ui (of glitch) doesn't appear to be graying out the button on though (clicking the follow button still shows a "403 - action not allowed" pop-up - which makes sense). and yep, the reasoning makes sense, i'll probably remove it then!