search

sk2589822 / Exhentai-Enhancer

A user script to improve UX of Exhentai
MIT License
23 stars 1 forks source link

Is there any way to trigger the download popups from the front/search page as well? #58

Closed i-am-at0m closed 7 months ago

i-am-at0m commented 10 months ago

Like how would this need to be changed to make that happen?

sk2589822 commented 10 months ago

Hi, I didn't implement feature like this. I will take a look to see if this is feasible when I have time.

sk2589822 commented 10 months ago

Hi @i-am-at0m

I haven't started working on it yet, but I've given it some thought.

The way I've implemented the popups on the gallery page is as follows:

  1. Preloading the torrents/direct download page.
  2. Inserting the green check icon after the download link once the preloads are finished.
  3. Showing the content when the user clicks the download link.

For the front page, I can add a direct download button (torrents download link already exists) to every gallery, but it's unrealistic to preload all the torrents/direct download pages on the front page.
I believe it would make more sense to load them after the user clicks the download link and display the content once the download is finished.
However, this method might be slower than what you experienced on the gallery page because it only starts downloading after you click the button.

I'm not sure if this approach is feasible, but I will find time to try it.

i-am-at0m commented 10 months ago

Agreed, preloading that sounds like mess. Honestly being slow isn't the worst if it means I don't have to click into the gallery to bring up the downloads prompt.

On Sun, Jan 7, 2024, 21:40 JK @.***> wrote:

Hi @i-am-at0m https://github.com/i-am-at0m

I haven't started working on it yet, but I've given it some.

The way I've implemented the popups on the gallery page is as follows:

  1. Preloading the torrents/direct download page.
  2. Inserting the green check icon after the download link once the preloads are finished.
  3. Showing the content when the user clicks the download link.

For the front page, I can add a direct download button (torrents download link already exists) to every gallery, but it's unrealistic to preload all the torrents/direct download pages on the front page. I believe it would make more sense to load them after the user clicks the download link and display the content once the download is finished. However, this method might be slower than what you experienced on the gallery page because it only starts downloading after you click the button.

I'm not sure if this approach is feasible, but I will find time to try it.

— Reply to this email directly, view it on GitHub https://github.com/sk2589822/Exhentai-Enhancer/issues/58#issuecomment-1880312967, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHROW7VOGF4N5N2DXQCXF3YNNMBNAVCNFSM6AAAAABAYQMS3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGMYTEOJWG4 . You are receiving this because you were mentioned.Message ID: @.***>

sk2589822 commented 9 months ago

Hi @i-am-at0m,

I've just completed this feature.
However, I'm unable to test if it works as expected because my H@H has been revoked a while ago. So Let me know if there are any issues, thanks!

i-am-at0m commented 9 months ago

Doesn't look like it. One of the times I loaded while switching views I saw a bunch of little A buttons in thumbnail view but haven't seen them again since. And when I tried to click, I got a yellow banner saying the link didn't exist., tried to refresh and they disappeared

Running 1.12 on Firefox nightly on Android.

sk2589822 commented 9 months ago

Have you logged in your account? I use the e-hentai API for getting the content of download page, which required a logged in cookie.

I've also fix a issue in 1.12.1 about using incorrect API for e-hentai (didn't notice it because I usually use exhentai).
Not sure if you were visiting e-hentai or exhentai.

If it still not works after logged in & update to 1.12.1. Can you try it on a PC to see if it's work?

The warning toast (yellow banner) will only shows when

  1. set Action when clicking "Archive Download" to download 2400x Resolution with H@H. image
  2. the 2400x option is N/A H@H.

After showing warning toast, the archiver download popup should shows as well.

i-am-at0m commented 9 months ago

In 1.12.0: Quality is set to send original to hath and works elsewhere.

I do use e-h so that might be a reason

Warning toast has text implying it's got a link to open the prompt but nothing happened even I tried to click it.

Won't have time to check 1.12.1 until a bit later from mobile or pc

On Sun, Jan 14, 2024, 02:03 JK @.***> wrote:

Have you logged in your account? I use the e-hentai API for getting the content of download page, which required a logged in cookie.

I've also fix a issue in 1.12.1 about using incorrect API for e-hentai (didn't notice it because I usually use exhentai). Not sure if you were visiting e-hentai or exhentai.

If it still not works after logged in & update to 1.12.1. Can you try it on a PC to see if it's work?

The warning toast (yellow banner) will only shows when

  1. set Action when clicking "Archive Download" to download 2400x Resolution with @.*** image.png (view on web) https://github.com/sk2589822/Exhentai-Enhancer/assets/25762718/8afbf897-bc17-4547-8653-b307ccae2dbf
  2. the 2400x option is N/A @.***

After showing warning toast, the archiver download popup should shows as well.

— Reply to this email directly, view it on GitHub https://github.com/sk2589822/Exhentai-Enhancer/issues/58#issuecomment-1890866961, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHROW7T67ZC7PW6QQDC53TYON7KRAVCNFSM6AAAAABAYQMS3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQHA3DMOJWGE . You are receiving this because you were mentioned.Message ID: @.***>

i-am-at0m commented 8 months ago

Just wanted to follow up, 1.12.1 isn't working for me either for this feature.

sk2589822 commented 8 months ago

Could you provide more information like browser, browser version, OS, error messages in devtools console, etc.?

A video with your operation is even better.

AlexanderHel commented 8 months ago

wonder if the same can do for rating

i-am-at0m commented 8 months ago

Looks like the little A to trigger this only pops up in thumbnail view. Anything else and it isn't there. But it does work in that view.

On Thu, Feb 22, 2024, 04:59 JK @.***> wrote:

Could you provide more information like browser, browser version, OS, error messages in devtools console, etc.?

A video with your operation is even better.

— Reply to this email directly, view it on GitHub https://github.com/sk2589822/Exhentai-Enhancer/issues/58#issuecomment-1959090396, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHROW56B4IT2HASQPDHWP3YU4JGJAVCNFSM6AAAAABAYQMS3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZGA4TAMZZGY . You are receiving this because you were mentioned.Message ID: @.***>

sk2589822 commented 8 months ago

wonder if the same can do for rating

Sorry @AlexanderHel, since I don't typically use rating function, I don't intend to implement this feature.

sk2589822 commented 8 months ago

@i-am-at0m

Looks like the little A to trigger this only pops up in thumbnail view.

Yes, all of the features in this script were built based on thumbnail view which I usually used.
Like I mentioned here

image

i-am-at0m commented 7 months ago

Gotcha. Can you at least make the button bigger then?

sk2589822 commented 7 months ago

Sure, I just enlarged it from 12px to 24px in v1.12.2.

For the sake of minimizing visual disruption to the website, I initially made it the same size as the torrent button. However, if this made it difficult to click, it would defeat the purpose.

sk2589822 commented 7 months ago

close by fb33d56c46d96b0bb5f882b75092f9e7aaa5c1a9