search

sk3pp3r / speedtest2zabbix

a speedtest script based `speedtest` version 2.0.0. that check Download, Upload and WAN-IP and report to Zabbix.
GNU General Public License v3.0
8 stars 7 forks source link

Variables not called #1

Closed waynieoaks closed 4 years ago

waynieoaks commented 5 years ago

Hi

Firstly, thank you for such a great script.

I have found a couple of issues when trying to run that have debugged as being caused by the following:

spd.sh

lines 84 - 90 echo "SpeedTest" replaced with echo $ZABBIX_HOST

line 96 ZABBIX_SERVER_IP_OR_FQDN replaced with $ZABBIX_SRV

After which it seems to be working without issue.

Many thanks.

sk3pp3r commented 5 years ago

Hi

Firstly, thank you for such a great script.

I have found a couple of issues when trying to run that have debugged as being caused by the following:

spd.sh

lines 84 - 90 echo "SpeedTest" replaced with echo $ZABBIX_HOST

line 96 ZABBIX_SERVER_IP_OR_FQDN replaced with $ZABBIX_SRV

After which it seems to be working without issue.

Many thanks.

Hi, You're more than welcome to fork, make a new branch and open a pull request.

GitHub Standard Fork & Pull Request Workflow https://gist.github.com/Chaser324/ce0505fbed06b947d962

waynieoaks commented 4 years ago

Hi

Thank you - I have (hopefully) done that correctly.