search

sk7725 / BetaMindy

A java mod of Mindustry, made for testing and doing chaotic fun.
GNU General Public License v3.0
330 stars 70 forks source link

Gone go the deprication errors #124

Closed MEEPofFaith closed 2 years ago

MEEPofFaith commented 2 years ago

Should I also delete the Extension thing? Eh, might as well.

sk7725 commented 2 years ago
  1. lots of unnecessary import changes: especially don't touch the unwildcarded static imports (wildcarding normal imports are fine)
  2. dont touch my MindySounds; l() copypasta is the closest thing ill get to an autogenerate annotation
  3. dont delete Extension
  4. you mixed up uiIcon and fullIcon for cases too many to list here
  5. revert expandedn't, as it does have use that i pr'd in (im gonna pr to remove the @Deprecated on that to anuke later)
  6. as soon as i get home im going to look through it more closely
sk7725 commented 2 years ago

Tips on point 4: Cicon.medium should be changed to uiIcon (mostly) and Cicon.full should be changed to either fullIcon (sometimes) or uiIcon (other times) for Cicon.large or others, ask me

MEEPofFaith commented 2 years ago

hhh