search

ska-sa / astrokat

General observation framework for the MeerKAT telescope
BSD 2-Clause "Simplified" License
2 stars 4 forks source link

Issue noisediode deactivation to happen now #118

Closed bngcebetsha closed 11 months ago

bngcebetsha commented 1 year ago

As reported in OPS-2080, the observation script switches the noisediodes off at the end of observations. There have been issues on site where lost connection to a receptor results in failure to switch the noisediodes off on all other antennas on the array, which reports a failure. Here we attempt to mitigate that by using the current time as the time to reset the noisediode.

PLEASE NOTE

We still need to test this, so please take this as a draft PR.

JIRA: MT-3844

lanceWilliams commented 12 months ago

@ludwigschwardt just following up on this: so would you be ok if we removed the noise diode off command in https://github.com/ska-sa/astrokat/blob/f7e29ce091100a6041c61a8f3974f7b6a2611adf/astrokat/observe_main.py#L301 (and rely on session to do it) and then retain the function Buntu has created to turn noisediodes off with the 'now' timestamp on the way out of the schedule block in the exit function ?

ludwigschwardt commented 12 months ago

Lance, your suggestion makes sense. I don't switch them off on the way out, just on the way in.