Update to require at least C++17

ska-sa / spead2

Library for the Streaming Protocol for Exchange of Astronomical Data (SPEAD)

http://spead2.readthedocs.io/en/latest/

GNU Lesser General Public License v3.0

23 stars 14 forks source link

Update to require at least C++17 #239

Closed bmerry closed 1 year ago

bmerry commented 1 year ago

There are many simplifications made possible by requiring C++17, and some optimisations (mostly from C++14 lamba initialisers allowing data to be moved rather than copied into lambdas). Apart from those, there are a few more major changes:

common_bind.h is deleted. It wasn't being used anywhere.
a new storage class is introduced to provide a safer alternative to std::aligned_storage (which is deprecated in C++23)
testing now covers a wider range of compiler versions

bmerry commented 1 year ago

@sjperkins the Github interface only seems to let me request reviews from certain people so I can't tag you for review, but please take a look when convenient.

@rtobar @ajameson let me know if you hit any compiler issues with this branch.

rtobar commented 1 year ago

Compiles here (standalone and python package) with g++ 12.2.0 on Ubuntu 22.10.

I had other compilation woes though, will report separately.