Closed bmerry closed 9 months ago
I presume that the macos failures are addressed in #306 ?
Will take a look @bmerry. Ideally, when you like this reviewed by?
I presume that the macos failures are addressed in https://github.com/ska-sa/spead2/pull/306 ?
Yes, that's the theory.
Will take a look @bmerry. Ideally, when you like this reviewed by?
Thanks! This week would be great if you have the time.
Is the changed behaviour covered by existing test cases in https://github.com/ska-sa/spead2/pull/294?
More-or-less - the hairy bits anyway. The begin()
and end()
functions on the ringbuffer
class aren't covered in the tests, but they're pretty trivial, and I'm developing more example code for a tutorial so I'm happy that it's working at the moment (and if it's broken at compile time I'll find out about it).
This allows this pattern:
to be replaced by
This was previously implemented for class
ring_stream
in #294. This PR makes the iterator implementation more generic and applies it to classringbuffer
as well.