search

ska-sa / spead2

Library for the Streaming Protocol for Exchange of Astronomical Data (SPEAD)
http://spead2.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
23 stars 14 forks source link

fixed the PDF version generation #359

Closed shaoguangleo closed 3 weeks ago

shaoguangleo commented 3 weeks ago

When I try to download the PDF version in spead2, It crashed. After checking the compile log, it looks like the error was caused by the SVG file.

! LaTeX Error: Cannot determine size of graphic in *.svg

This should fix the PDF generation host on the readthedocs.io, it works on my laptop at least.

james-smith-za commented 3 weeks ago

@bmerry I have approved the CI run, but I'll hold off on merging until you give the go-ahead.

Thanks for that @shaoguangleo!

bmerry commented 3 weeks ago

@shaoguangleo thanks for raising this. I'm going to go with #360 instead though, which avoids rasterising the vector images.

shaoguangleo commented 3 weeks ago

@bmerry Hi Bruce, thanks for your debug. The method metioned #359 worked on my MacBook, but the CI/CD failed. I've already tried to fetch the branch you created #360 which was failed on my MacBook, but looks like the CI/CD works. It looks weird, maybe caused by different PYTHON version. It's 3.10 on my laptop. I can not open the PDF on https://spead2.readthedocs.org/ right now, so maybe this will work after you merge the PR to the main branch. So feel free to close this PR after #360 works.

@shaoguangleo thanks for raising this. I'm going to go with #360 instead though, which avoids rasterising the vector images.

bmerry commented 3 weeks ago

It looks like the PDF docs on readthedocs are working now, so I'm going to close this. If you notice any problems with the docs then feel free to open an issue.