1. Prepare for futurize stage 1 and clean up repository

ska-sa / tango-simlib

Generic data-driven device simulator generation for PyTango

BSD 3-Clause "New" or "Revised" License

6 stars 2 forks source link

1. Prepare for futurize stage 1 and clean up repository #105

Closed amakhaba closed 4 years ago

amakhaba commented 4 years ago

This PR does the following (Prepare for Futurize stage 1):

Added the migration tox.ini file
Updated the Jenkinsfile and setup.py
Repository cleanup (grammar, imports and whitespaces related fixes)

Definition of Done Checklist

[x] Unit tested (coded, passed, included)?
[x] Requested at least 2 reviewers?

JIRA: MT-738

mmphego commented 4 years ago

Looks good, but I think at this current moment we do not need tox. We can continue without it as the tests are run via python nosetests and I do not think we should only keep tox for docs generation (Wouldn't make sense).

I suppose, if we have enough time towards the end of the sprint then we can revisit the use of tox and how we can get tests to run but till then please remove the tox.ini file.

@ajoubertza and @tockards what do you think?

ajoubertza commented 4 years ago

I suppose, if we have enough time towards the end of the sprint then we can revisit the use of tox and how we can get tests to run but till then please remove the tox.ini file.

No tox for this repo is fine. I don't mind if it is removed now or in a later PR. When removed, then restore the extras_require as well.

mmphego commented 4 years ago

@ajoubertza Additional cleanup done, this time to the whole repository.

PR ready to be merged.