search

ska-sa / tango-simlib

Generic data-driven device simulator generation for PyTango
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

registering devices for no db option #84

Closed ghost closed 6 years ago

ghost commented 6 years ago

There is no need to register devices when using a file as the db. The current implementation in tango_launcher tried to fetch the device list from the real tango DB and went on to start the device server using a default test name test/nodb/tangodeviceserver which does not match devices registered in the file.

current implementation

https://github.com/ska-sa/tango-simlib/blob/b72e486a1eff97bdb9dae6f469600c355f30e9d1/tango_simlib/tango_sim_generator.py#L460-L477

This PR addresses the run time error encountered (image below) when the kat-tango-sim-launcher script executes.

screen shot 2018-07-26 at 07 36 13
ajoubertza commented 6 years ago

@lvdheever Please review again, after latest changes.

ghost commented 6 years ago

@ajoubertza thanks for pointing out the need for the PR description update.