search

ska-telescope / lmc-base-classes

LMC Base Classes Software Development Kit Project
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Modified unit test cases for SKABaseDevice and SKAMaster #82

Closed adityadangeska closed 6 years ago

flyingfrog81 commented 6 years ago

As I suspected, this is going into technical details of the package, and I agree that @lochanitis is the best to review this at this stage. What I see is that you are filing in previously empty fields, and that should be ok provided the values are correct. Do the test pass in your local environment?

lochanitis commented 6 years ago

Yes @flyingfrog81 , as mentioned by @adityadangeska in report, we are able to get more test cases passed at our end.

flyingfrog81 commented 6 years ago

Thanks @ajoubertza for the review, that's the way to go. Everyone learns in this process and code quality improves, whilst establishing a common base of knowledge.

ajoubertza commented 6 years ago

@aditya There are a number of comments that you have marked resolved/done, but I don't see any new commits on this PR. Did you push your changes yet?

adityadangeska commented 6 years ago

@aditya There are a number of comments that you have marked resolved/done, but I don't see any new commits on this PR. Did you push your changes yet?

Hi Anton, I havent pushed my changes yet. I am busy with some other work.