Removed unwanted methods from SKABase and SKAMaster

ska-telescope / lmc-base-classes

LMC Base Classes Software Development Kit Project

BSD 3-Clause "New" or "Revised" License

3 stars 4 forks source link

Removed unwanted methods from SKABase and SKAMaster #83

Closed adityadangeska closed 5 years ago

adityadangeska commented 5 years ago

Not sure why PR #82 was closed, and most of those changes added again in this new PR? Also, some comments in that PR have still not been addressed.

That was due to some misunderstanding about how github works.

Please add a proper description and title to the PR. "Aditya" is not a good title.

Agree. Cannot remember how "Aditya" was entered. Might be some copy paste error. Will take care in future.

ajoubertza commented 5 years ago

Agree. Cannot remember how "Aditya" was entered.

Github automatically uses the branch name as the title for a new PR if it has more than one commit. Click the Edit button to the right of the description to fix both the title and the detailed description.

adityadangeska commented 5 years ago

Closing this PR as this branch is stale now.