search

skaarj1989 / mWebSockets

WebSockets for microcontrollers
https://skaarj1989.github.io/mWebSockets/autobahn-testsuite/servers/
MIT License
108 stars 23 forks source link

use build_flags on platformio instead of editing config.h #61

Closed paulkilroy closed 1 year ago

paulkilroy commented 1 year ago

If you're using platformio and have this library included in dep_libs it will automatically download and compile with it (very nice and easy). Then, I can edit the config.h in the dep_libs directory...

But I think it would be easier to just edit the platformio.ini file with a -DNETWORK_CONTROLLER=3, then all your platform specific edits are in one place. But to do this, it would require you to change config.h to have an #ifndef NETWORK_CONTROLLER around it so the compiler doesn't get upset about a redefined #define. The upshot of this is that its completely backwards compatible with your current scheme.

Thanks

skaarj1989 commented 1 year ago

At the moment I don't have PlatformIO, when I fix this, can you use the master branch, or do you need a new release?

paulkilroy commented 1 year ago

Sure - Happy to help, but I apologize but I’m still a bit new to Git. I can include any library based on the following structure/syntax in PlatformIO. Hope that helps.

pio lib [STORAGE_OPTIONS] install (with no args, install project dependencies from "lib_deps") pio lib [STORAGE_OPTIONS] install <ownername/name> pio lib [STORAGE_OPTIONS] install ownername/name>@<version pio lib [STORAGE_OPTIONS] install <ownername/name>@ pio lib [STORAGE_OPTIONS] install pio lib [STORAGE_OPTIONS] install file:// pio lib [STORAGE_OPTIONS] install file:// pio lib [STORAGE_OPTIONS] install pio lib [STORAGE_OPTIONS] install = (name it should have locally) pio lib [STORAGE_OPTIONS] install <repository#tag> ("tag" can be commit, branch or tag)

By the way, the reason I switched to PlatformIO is the WokWi simulator. It’s pretty amazing and can run on the web, but also inside VSCode/PlatformIO. I can run / test / debug all in that environment and can’t go back to Arduino IDE.

On Wed, Feb 15, 2023 at 4:48 AM David @.***> wrote:

At the moment I don't have PlatformIO, when I fix this, can you use the master branch, or do you need a new release?

— Reply to this email directly, view it on GitHub https://github.com/skaarj1989/mWebSockets/issues/61#issuecomment-1431034196, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMVBG4YG6RWOYUNUI4ETMU3WXSQ7TANCNFSM6AAAAAAU4IWXOM . You are receiving this because you authored the thread.Message ID: @.***>

skaarj1989 commented 1 year ago

Done.

paulkilroy commented 1 year ago

Works great - Thanks!

On Fri, Feb 17, 2023 at 9:13 AM David @.***> wrote:

Done.

— Reply to this email directly, view it on GitHub https://github.com/skaarj1989/mWebSockets/issues/61#issuecomment-1434785315, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMVBG455VALPU2LFMKQAZ63WX6IPZANCNFSM6AAAAAAU4IWXOM . You are receiving this because you authored the thread.Message ID: @.***>