search

skade / leveldb-sys

MIT License
7 stars 15 forks source link

Update LevelDB #14

Closed ghost closed 4 years ago

ghost commented 4 years ago

Hi @skade,

This PR updates LevelDB to 1.22 and Snappy to 1.1.7. In particular, it means that he build is done using CMake now.

Additionally, it removes Cargo.lock because Cargo FAQ says that library crates should not have Cargo.lock in the repository.

Because adding CMake dependency is a breaking change, I think the version of leveldb-sys crate should be bumped to 3.0.0.

ghost commented 4 years ago

I considered using leveldb and snappy as Git submodules, but haven't done it yet as it might break things for people who build the crate without network connection.