skade / leveldb-sys

MIT License
7 stars 15 forks source link

Replace opaque types #20

Closed skade closed 3 years ago

skade commented 3 years ago

We still use:

enum opaque {}

This has subtle issues that usually don't appear in practice (only if you dereference them).

Still, the current recommendation for opaque types is:

struct opaque{ priv: [u8;0]}

and should be used for cleanliness.

skade commented 3 years ago

Fixed by: https://github.com/skade/leveldb-sys/pull/23