search

skade / leveldb-sys

MIT License
7 stars 15 forks source link

Add support to correctly build on FreeBSD #8

Closed pizzamig closed 5 years ago

pizzamig commented 5 years ago

This patch will add support to FreeBSD. The build.rs is recognizing FreeBSD using the TARGET environment variable, then configuring the build to use gmake instead of the incompatible make

skade commented 5 years ago

@pizzamig Thanks for this patch. I'm willing to accept it, but have a question there: how does this case look like on other BSDs, like Net? I don't want to over-specify there.

pizzamig commented 5 years ago

The current situation is that the build is broken on every system not using GNU Make. For what I know, no BSD uses GNU Make. However, I'm not sure how the GNU Make is called on other BSDs. I think the TARGET recognition can be relaxed using "bsd" instead of "freebsd" (and variable names changed accordingly). It should work as long as gmake is installed. I'll update the PR

skade commented 5 years ago

@pizzamig Thanks! I also tweeted around to see if I can get some eyes on that from other BSD folks.

skade commented 5 years ago

Seems legit!

skade commented 5 years ago

I'll merge and cut a release a little later today.

skade commented 5 years ago

Released as 2.0.3.

pizzamig commented 5 years ago

Thanks a lot!