search

skadistats / clarity-examples

Example code for clarity
BSD 3-Clause "New" or "Revised" License
113 stars 37 forks source link

Is there data for fights in the demo? The "show fight recap" button of dota 2 client #49

Closed Markxy closed 3 years ago

Markxy commented 3 years ago

I'm looking if there's any data embedded in the demo associated with fights. I'm talking about these when watching a demo: image

It could be that the client is just simply collecting all the data by itself and the demo doesn't contain that info. I also know that it could be doable based on kills, damage dealt, abilities used, etc - Opendota parses the demo and creates it's own thing where they decide what is a teamfight and what's not.

But what I'm wondering is that is the data already there? And if so, how should I go about looking for it? If I know the tick of the popup, could I dump all of the demo's info close to that tick somehow and see if that contains anything?

I went through clarity-examples but no output seemed to contain this.

Any pointers?

spheenik commented 3 years ago

I'm pretty confident the data is not there. The way of finding out definitively is to look at the list of all the different messages that can be found in the replay:

EmbeddedPackets

The ones that are commented out are defined in the game, but have never been seen in a replay. It might be that the ones NOT commented are also NOT in the replay, but most of them are.

If you look at the file, there is no teamfight, summary, etc. in it. So you must use the same approch as the opendota guys.

Good luck!

Markxy commented 3 years ago

Thanks, @spheenik !

Yeah it looks like you're right, I went over them multiple times and didn't find anything significant. Manual parsing it is.

Closing the question. Thanks again 🙂