search

skadistats / clarity

Comically fast Dota 2, CSGO, CS2 and Deadlock replay parser written in Java.
BSD 3-Clause "New" or "Revised" License
664 stars 122 forks source link

String Comparisons #300

Closed STRATZ-Ken closed 1 year ago

STRATZ-Ken commented 1 year ago

@spheenik

What is your thoughts on your OnPropertyChanged and similar endpoints. Looking under the hood, these are string comparisons. Can't wait get these from FieldPaths, cache the results then be able to do FieldPath lookups directly?

https://github.com/skadistats/clarity/blob/master/src/main/java/skadistats/clarity/processor/entities/PropertyChange.java#L63

spheenik commented 1 year ago

Performance-wise, @OnPropertyChanged should be avoided at all costs. It is very expensive.

STRATZ-Ken commented 1 year ago

What about other Methods, @OnEntityCreated, @OnEntityUpdated, etc.

spheenik commented 1 year ago

They are fine, and the recommended way to use.