search

skadistats / clarity

Comically fast Dota 2, CSGO, CS2 and Deadlock replay parser written in Java.
BSD 3-Clause "New" or "Revised" License
663 stars 122 forks source link

Fix #316: Change HeroID_t type #317

Closed Rupas1k closed 2 months ago

Rupas1k commented 4 months ago

Using IntVarSignedDecoder instead of IntVarUnsignedDecoder for HeroID_t seems to solve this issue.

STRATZ-Ken commented 4 months ago

@spheenik Can we get this merged and built?

spheenik commented 4 months ago

Did anyone check that this does not break old replays?

Rupas1k commented 4 months ago

Did anyone check that this does not break old replays?

Before new patch it was encoded as int32 so it doesn't break anything

http://replay273.valve.net/570/7831330794_891467511.dem.bz2 - July 6 and hero id is encoded as "int32" http://replay161.valve.net/570/7842220004_1918640619.dem.bz2 - July 12 and here is where "HeroID_t" appears