Open spheenik opened 8 years ago
another one but from using combat log example:
unknown embedded message of kind SOURCE2/523. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
unknown embedded message of kind SOURCE2/540. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
unknown embedded message of kind SOURCE2/529. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
unknown embedded message of kind SOURCE2/574. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
unknown embedded message of kind SOURCE2/556. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
These look like user-recorded demos, right? Most of the message types listed are normally not saved in the replay (just broadcast to teammates).
Yes, these are recorded using the DOTA console. The output for the combat_log example though doesn't output any data other than the unknown embedded message which I find odd. I included one of the replayfile I used (small enough to be uploaded)
@huertasdanny: Enabled the missing messages in clarity-protobuf 4.20, which I uploaded to maven central right now.
match_id: 5305773896 unknown embedded message of kind SOURCE2/571.
@PeaXCD: Pushing 4.21 now, which has the message enabled.
Since yesterday's battle pass update:
unknown embedded message of kind SOURCE2/597
@omorgan7: Thanks, I suspected such...
I was quick today, and am pushing a new version (4.24) of the protobufs to central as we speak.
unknown usermessage message of kind CSGO/75
damit du was zu tun hast :-*
unknown embedded message of kind SOURCE2/604. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
unknown embedded message of kind SOURCE2/579.
Sorry for taking so long - I'm a lazy ass.
pushing to central right now.
unknown usermessage message of kind CSGO/69
unknown embedded message of kind SOURCE2/605 unknown embedded message of kind SOURCE2/606
unknown embedded message of kind SOURCE2/144 unknown embedded message of kind SOURCE2/106.
Version 4.26 released:
add CSGO/69
add SOURCE2/106 add SOURCE2/144 add SOURCE2/605 add SOURCE2/606
unknown embedded message of kind SOURCE2/610
Version 4.27 released:
add SOURCE2/612 (DOTA_UM_ChatMessage)
unknown embedded message of kind SOURCE2/611
CSGO/11 on map 3 (dust2) of replay: https://demos.hltv.org//demo/demofiles/demosection/United-Masters-League-Season2-sprout-vs-giants-bo3.rar
unknown embedded message of kind SOURCE2/114
SOURCE2/114 SOURCE2/496 SOURCE2/608 SOURCE2/499 SOURCE2/562 SOURCE2/531
SOURCE2/154
Dota 2 match 6742168610
[pool-2-thread-4] WARN clarity.runner - unknown embedded message of kind SOURCE2/154. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
unknown embedded message of kind SOURCE2/154. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58 match is : 6792799128
6792839364 [unknown embedded message of kind SOURCE2/154. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58]
updating clarity dependencies in pom.xml seems to be fixed the issue (I missed version release update, sorry)
SOURCE2/617 SOURCE2/616
6856094991
HI hi!
14:18:04.634 WARN unknown embedded message of kind **SOURCE2/154**. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58 14:18:04.673 ERROR Runner thread crashed java.lang.ArrayIndexOutOfBoundsException: Index 5 out of bounds for length 5
Let me know if I can help.
Cheers
o/
The exception is unrelated to the warning. Can you provide the replay?
The exception is unrelated to the warning. Can you provide the replay?
This is the match ID: 6890930297 Glad if I can help
Thanks, will look into it
Can I ask what is an unknown message type? :)
At the lowest level, the replay is a collection of "messages", or "packets", which are encoded with potobuf. On disk, only a packet type (as an int) is stored, so clarity needs to know, which protobuf message type has to be decoded how. This is done with the definitions in the package https://github.com/skadistats/clarity-protobuf.
So when clarity encounters a package type, it has no definition for, it warns you with this message. Valve add new message types every once in a while, and I have to update clarity-protobuf accordingly, which I did not do for quite a while, since I am a lazy bastard.
So you have to find the definition somewhere, (but where?) and update clarity-protobuf. I see that the repository has not been updated for 2 years, how is that possible? I see that this issue thread is quite active... Does it have to do with Maven Central? Like, clarity-protobuf being updated on Maven and not on GitHub?
Can I help keeping clarity-protobuf up to date?
There is a project on Github that extracts the protobuf definitions from the game regularly.
https://github.com/SteamDatabase/GameTracking-Dota2
My approach is not to simply copy their definitions completely, since many of them are not needed for parsing demos, and sometimes they remove fields also, and I keep those fields in my definitions, since I want older replays to also be able to be read.
It's true I didn't update for a long time, and should do so. But since the "core definitions" do not change, and there are mostly new UserMessages that will not be of interest for replay parsing anyway, I just figured it's priority B.
There is a project on Github that extracts the protobuf definitions from the game regularly.
https://github.com/SteamDatabase/GameTracking-Dota2
My approach is not to simply copy their definitions completely, since many of them are not needed for parsing demos, and sometimes they remove fields also, and I keep those fields in my definitions, since I want older replays to also be able to be read.
I see, your approach has some careful steps to take. I propose you and/or I could make a page in the wiki on this repository (or clarity-protobufs) in GitHub and explain the steps. So if I or someone else who wanted to help keeping clarity-protobufs updated, could follow those steps and produce pull requests.
How does it sound to you?
It's true I didn't update for a long time, and should do so. But since the "core definitions" do not change, and there are mostly new UserMessages that will not be of interest for replay parsing anyway, I just figured it's priority B.
I followed your advice from time ago and started from clarity-examples and clarity-analyzer to be able to understand how to parse game events. Until I learn to do it, I wanted to use Clarity Analyzer to read through a replay quickly, to understand what variables I can parse with clarity. But these unknown message types make Analyzer crash. The next best thing is to use clarity-examples to dump the entire replay, which is not great for a beginner like me, but I make do with what I have.
I'd be glad to help in the little free time I have. PS: when submitting in this issue 58, is it enough to post just one match ID?
Unknown message ids should not make analyzer crash. The crash is most surely related to something else.
Unknown message ids should not make analyzer crash. The crash is most surely related to something else.
Ah, sorry. I did not understand it. That's what you meant when you said the warning and the exception are not related to each other.
Can I help with the crash as well? Should I open a new issue for the crash to separate it from this thread?
The analyzer crash is most certainly because it uses an old version of clarity. It should work if it uses 2.7.5.
The analyzer crash is most certainly because it uses an old version of clarity. It should work if it uses 2.7.5.
Oh thank you, it was that... it works now.
Let me know if I can help with the other stuff we talked about, glad if I can.
Detailing the above details here: faq
I too am experiencing the above mentioned issue:
unknown embedded message of kind SOURCE2/154.
Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
Using git repo: clarity-examples
@ commit
Clarity version: 2.7.5
commit
with replay ID: 6963982486.dem
, but as @spheenik explained above, he still needs to (1) extract the new protobuf definitions and (2) tweak the definitions to enable backwards compatible replay parsing.
Let me know if I misunderstood anything 🙇
Detailing the above details here: faq
I too am experiencing the above mentioned issue:
unknown embedded message of kind SOURCE2/154. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
Using git repo:
clarity-examples
@ commit Clarity version:2.7.5
commitwith replay ID:
6963982486.dem
, but as @spheenik explained above, he still needs to (1) extract the new protobuf definitions and (2) tweak the definitions to enable backwards compatible replay parsing.Let me know if I misunderstood anything 🙇
Thank you for starting the wiki! I did not know if we were allowed to do it. About your understanding, that's what I got as well.
New protobufs have been released.
Added SOURCE2/114 (CUserMessageRequestState) SOURCE2/154 (CUserMessageServerFrameTime) SOURCE2/496 (CDOTAUserMsg_SwapVerify) SOURCE2/499 (CDOTAUserMsg_ItemAlert) SOURCE2/531 (CDOTAUserMsg_PlayerMMR) SOURCE2/562 (CDOTAUserMsg_KillcamDamageTaken) SOURCE2/608 (CDOTAUserMsg_AghsStatusAlert) SOURCE2/616 (CDOTAUserMsg_DuelOpponentKilled) SOURCE2/617 (CDOTAUserMsg_DuelAccepted)
My testing capability was limited, since downloading replays through the client seems buggy atm. (Opendota also does not work).
Regarding the Wiki Thing: Doing a FAQ there is probably really a good thing. @darrensapalo Mind if I change your entry to properly explain this?
Oh, and, the protobufs contain several extra combatlog properties. If you want to use them, I released clarity 2.7.6. Pushed both artifacts to central five minutes ago, so might be an hour or so before you see them.
@spheenik Please do! I'll follow your lead on the docs. Thanks spheenik!
unknown top level message of kind CSGO_S2/16
also no decoder for class CCSPlayerController at 19/11!
since the update today
Not sure how to be more helpful, but I got a
WARN clarity.runner - unknown top level message of kind CSGO_S2/16. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58
I was trying to parse the first map of this game https://www.hltv.org/matches/2370928/liquid-vs-faze-iem-chengdu-2024 Using the version 3.0.3
unknown top level message of kind CSGO_S2/16. Please report this in the corresponding issue: https://github.com/skadistats/clarity/issues/58 on tick 152 of the cs2 replay: https://www.hltv.org/matches/2370727/faze-vs-natus-vincere-pgl-cs2-major-copenhagen-2024 map-3-Inferno
Thank you guys, CSGO_S2/16
noted, I'll put updating the protobufs to my not so small list of todos.
If you come here, you know why. Thanks for your help!