search

skadogg / personal-tv-guide

Python-based JustWatch scraper
GNU General Public License v3.0
6 stars 7 forks source link

💄 Why are these different sizes? #91

Closed skadogg closed 7 months ago

skadogg commented 7 months ago

I just noticed that the left and right sides of the badges / shields are different sizes. Here's what I see, zoomed to 250%:

image

This is probably just some kind of padding or spacing thing in nord.css. It would be great to have the right side be a bit bigger to match the size of the left.

code-master-ajay commented 7 months ago

Hi @skadogg, i can see in the nord.css file

For badge_main the padding is 5px. https://github.com/skadogg/personal-tv-guide/blob/3c2641490533460ae4429187cb4b858bd736b919/css/nord.css#L278

and for other badges red,green and blue the padding is 3px. https://github.com/skadogg/personal-tv-guide/blob/3c2641490533460ae4429187cb4b858bd736b919/css/nord.css#L302

maybe this is causing the issue.

Please let me know if this is correct, so i will open a PR for this.

skadogg commented 7 months ago

Hi, @code-master-ajay. You're right; I see the padding is too small for R, G, B, and badge_other. Would you please switch them all to 5px?

code-master-ajay commented 7 months ago

@skadogg Done.

skadogg commented 7 months ago

Thanks, @code-master-ajay!