search

skaes / logjam_core

the engine which powers the logjam application
GNU General Public License v3.0
56 stars 7 forks source link

Make livestream URL configurable #68

Closed maxlaverse closed 6 years ago

maxlaverse commented 6 years ago

This makes the livestream url configurable. Works on a Xingbox.

It think it would close https://github.com/skaes/logjam_core/issues/54

skaes commented 6 years ago

It's now configurable as a setter: https://github.com/skaes/logjam_core/commit/918921d17806cf3cb72c6ee21efc63a6d3665476

I changed config/initializers to read it from an ENV variable.

If not set, everything behaves as before: https://github.com/skaes/logjam_app/commit/efd5ee3956843b36e554581c1d067490df65d705

This does not solve #54 completely: if there's no WSS terminating proxy in front of the livestream server, a https connection will still not work.

maxlaverse commented 6 years ago

Thanks :)