Updates script to work now that python-rsvg doesn't seem to exist as a stand-alone package

bluesalt-labs commented 5 years ago

I was able to get this script to work after modifying it slightly and installing other python packages. I may have installed stuff I did not need to?

I apologize, I've never made a pull request before and I'm not sure if I'm going about this the right way. :)

skagedal commented 5 years ago

Hi! Thanks a lot for the pull request and sorry for the late reply :)

I would be happy to merge it and I'm sure you've done the right thing. I would only request that the changes to the README are made a little differently:

Keep the main structure as is - the README should begin with explaining what the repo is and what the tool does.
Add a new section "Installation" for the current paragraph that says "Make sure you have Inkscape..." and put your instructions there. Or perhaps call it "updated instructions 2019".
Add your name to that section so that one knows who the "I" refers to and so you get credit. (Alternatively, if you don't want that, please reword so that it is not in "I"-form)
If possible, make the apt instructions as brief as possible. Consistently use apt rather than apt-get (they are afaik synonyms).

Or something like that! I could perhaps also do these edits myself, but if you'd like to it would be great. :)

ynco commented 4 years ago

To get the script to work on Ubuntu 18.04 (with the modifications from this PR) I needed to install the following packages:

apt install gir1.2-rsvg-2.0 python-gi-cairo

I found the following packages mentioned in the (updated) README to not be required however:

libcanberra-gtk-module
libcanberra-gtk3-module
librsvg2-bin

skagedal / svgclip

Updates script to work now that python-rsvg doesn't seem to exist as a stand-alone package #2