search

skairunner / sky-oni-mods

Code for Sky's mods for the game Oxygen Not Included.
MIT License
18 stars 25 forks source link

Piped output for petroleum generator (PW) no longer working with CR #14

Closed Yaslana closed 5 years ago

Yaslana commented 5 years ago

Like title says, since the last update there seems to be some compatibility problem with piped outputs. On weekend everything worked fine. I also had some really bad framedrops while power generators were working but a reinstall of the mod seems to have helped here. I am using the steam mod. It says v. 1.1 while using the mod manager mod, but I can change nat gas output so I seem to have the current version?

skairunner commented 5 years ago

Hi,

Can you attach your log file? It is located at C:\Users\%USERNAME%\AppData\LocalLow\Klei\Oxygen Not Included\output_log.txt on Windows.

Also, can you describe what you mean by "not work"? Does the petrol generator simply not output anything, or does it output the wrong amount?

On Tue, Oct 22, 2019, 10:31 Yaslana notifications@github.com wrote:

Like title says, since the last update there seems to be some compatibility problem with piped outputs. On weekend everything worked fine. I also had some really bad framedrops while power generators were working but a reinstall of the mod seems to have helped here. I am using the steam mod. It says v. 1.1 while using the mod manager mod, but I can change nat gas output so I seem to have the current version?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/skairunner/sky-oni-mods/issues/14?email_source=notifications&email_token=AA22VOZVMVC3JGKIGLJLZMDQP4TE5A5CNFSM4JDSIZE2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTRYEKQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA22VO7AV5VGPWYRRGTCVTTQP4TE5ANCNFSM4JDSIZEQ .

Yaslana commented 5 years ago

Oh I am sorry, I mean I mean it dribbles everything on the floor, not using the output at all. The piped output works fine when I deactivate CR. output_log.txt

skairunner commented 5 years ago

This should work, I have pushed a new version.

Additionally, I noticed that your mod version is outdated--the current version is v1.3.2, and I released v1.3.1 yesterday. If today's update doesn't fix it, I would recommend manually installing Carbon Revolution locally. You can find the file here: https://github.com/skairunner/sky-oni-mods/releases/tag/CarbonRevolution_v1.3.2

Yaslana commented 5 years ago

Thanks for the fast fix! It still says 1.1 for me but the output works :)

skairunner commented 5 years ago

That's great! It seems that Ony's Mod Manager is using the wrong version for display--it should use AssemblyFileVersion, not AssemblyVersion. I suggest you ask her to fix it for accurate information!

On Tue, Oct 22, 2019, 12:43 Yaslana notifications@github.com wrote:

Thanks for the fast fix! It still says 1.1 for me but the output works :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/skairunner/sky-oni-mods/issues/14?email_source=notifications&email_token=AA22VO4CVPZT4BK2Q674Q5LQP5CVXA5CNFSM4JDSIZE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6Y4II#issuecomment-545099297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA22VO4XHRD7EQMEPV2IKYTQP5CVXANCNFSM4JDSIZEQ .