search

skairunner / sky-oni-mods

Code for Sky's mods for the game Oxygen Not Included.
MIT License
18 stars 25 forks source link

Carbon Revolution causing coal gens to start and stop and not produce power #41

Open jaydys opened 4 years ago

jaydys commented 4 years ago

When I enable the Carbon Rev mod my coal generators will pump once then go idle then pump once and go idle, rinse and repeat. So it will not produce any real power. When I disable the mod, everything works again. The only mod I have that works on coal gens is the piped output mod. I JUST installed it from steam so should have the latest version from steam. [Carbon Revolution] Started with version 1.5.0.

I have some screens with info. Coal Gen status. Settings of mod. output_log.txt

skairunner commented 4 years ago

Hi,

Unfortunately I haven't played or modded ONI in a while -- work has caught up to me and I've also lost interest in the game for now. So I'm not sure I will be able to get around to fixing my mods. Very sorry :(

On Sun, Jun 28, 2020, 18:11 jaydys notifications@github.com wrote:

When I enable the Carbon Rev mod my coal generators will pump once then go idle then pump once and go idle, rinse and repeat. So it will not produce any real power. When I disable the mod, everything works again. The only mod I have that works on coal gens is the piped output mod. I JUST installed it from steam so should have the latest version from steam. [Carbon Revolution] Started with version 1.5.0.

I have some screens with info. [image: Coal Gen status.] https://user-images.githubusercontent.com/45528006/85952534-8ee20500-b92f-11ea-8bb8-5a78d1c142ba.png [image: Settings of mod.] https://user-images.githubusercontent.com/45528006/85952540-930e2280-b92f-11ea-8733-7bbce37c4107.png output_log.txt https://github.com/skairunner/sky-oni-mods/files/4842579/output_log.txt

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/skairunner/sky-oni-mods/issues/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA22VO6UDNOEARP5YWPE3L3RY5TRXANCNFSM4OKTBKAA .

jaydys commented 4 years ago

Valid answer. Have a good one.

jaydys commented 4 years ago

Open/Close state? On the generators? I haven't changed anything. I don't mess with files. And the only mod I can think of that affects the gens are piped output and maybe the more capacity mods that both work fine without the Carbon Rev installed. So if I am not messing with the states and the mods I have installed do not seem to be doing it, where would I turn next?

On Sun, Jun 28, 2020 at 1:24 PM Skye Im notifications@github.com wrote:

Reopened #41 https://github.com/skairunner/sky-oni-mods/issues/41.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/skairunner/sky-oni-mods/issues/41#event-3490559515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK3LHRXNARERIANLVD6OGYTRY6DFXANCNFSM4OKTBKAA .

jaydys commented 4 years ago

Ok. Just ran a test on this to try and figure it out. And I just want to say that I only continue this because it seems like you want to figure this out as well since you reopened the ticket.

  1. Disabled all mods but carbon rev.
  2. Started new game in sandbox mode.
  3. Tested Coal Gen. No problems. Ran fine whether on battery or smart battery with auto wires.
  4. Turned on Piped Output mod. Gen still running fine.
  5. Piped CO2 out of gen into a container, issue occurred. (Generator swaps between enabled and idle within a subsecond cycle.)

So it looks like an issue between the actual use of piped output and the carbon rev mod. Trying different settings on CR mod. Seems that the lower the settings in CR the less of a pause in the Gen and it is able to output power close to a normal rate. But the higher the settings in CR the longer the pause, therefore, the slower the power gen. Output of CO2 is 1kg/s at the gen and the vents are getting 200g/s. So maybe an issue with the output capabilities of the piped mod. Took a quick look at the .dll for piped mod and didn't find any limits on the output, but I am a total noob when it comes to this type of modding.

So this may be an issue to take up with the Piped Output creator.

On Sun, Jun 28, 2020 at 11:06 PM Jason Poyner jason.l.poyner@gmail.com wrote:

Open/Close state? On the generators? I haven't changed anything. I don't mess with files. And the only mod I can think of that affects the gens are piped output and maybe the more capacity mods that both work fine without the Carbon Rev installed. So if I am not messing with the states and the mods I have installed do not seem to be doing it, where would I turn next?

On Sun, Jun 28, 2020 at 1:24 PM Skye Im notifications@github.com wrote:

Reopened #41 https://github.com/skairunner/sky-oni-mods/issues/41.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/skairunner/sky-oni-mods/issues/41#event-3490559515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK3LHRXNARERIANLVD6OGYTRY6DFXANCNFSM4OKTBKAA .

skairunner commented 4 years ago

If Piped Output has been updating, then it might be some kind of API mismatch. After all, Piped Output doesn't have any built in ways to allow other mods to hook into it, so I had to touch internals. If they changed how the mod works then Carbon Rev breaks.

On Wed, Jul 1, 2020, 15:54 jaydys notifications@github.com wrote:

Ok. Just ran a test on this to try and figure it out. And I just want to say that I only continue this because it seems like you want to figure this out as well since you reopened the ticket.

  1. Disabled all mods but carbon rev.
  2. Started new game in sandbox mode.
  3. Tested Coal Gen. No problems. Ran fine whether on battery or smart battery with auto wires.
  4. Turned on Piped Output mod. Gen still running fine.
  5. Piped CO2 out of gen into a container, issue occurred. (Generator swaps between enabled and idle within a subsecond cycle.)

So it looks like an issue between the actual use of piped output and the carbon rev mod. Trying different settings on CR mod. Seems that the lower the settings in CR the less of a pause in the Gen and it is able to output power close to a normal rate. But the higher the settings in CR the longer the pause, therefore, the slower the power gen. Output of CO2 is 1kg/s at the gen and the vents are getting 200g/s. So maybe an issue with the output capabilities of the piped mod. Took a quick look at the .dll for piped mod and didn't find any limits on the output, but I am a total noob when it comes to this type of modding.

So this may be an issue to take up with the Piped Output creator.

On Sun, Jun 28, 2020 at 11:06 PM Jason Poyner jason.l.poyner@gmail.com wrote:

Open/Close state? On the generators? I haven't changed anything. I don't mess with files. And the only mod I can think of that affects the gens are piped output and maybe the more capacity mods that both work fine without the Carbon Rev installed. So if I am not messing with the states and the mods I have installed do not seem to be doing it, where would I turn next?

On Sun, Jun 28, 2020 at 1:24 PM Skye Im notifications@github.com wrote:

Reopened #41 https://github.com/skairunner/sky-oni-mods/issues/41.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <https://github.com/skairunner/sky-oni-mods/issues/41#event-3490559515 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AK3LHRXNARERIANLVD6OGYTRY6DFXANCNFSM4OKTBKAA

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/skairunner/sky-oni-mods/issues/41#issuecomment-652432909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA22VO62653IDUB7RPOBHDLRZM52VANCNFSM4OKTBKAA .

jaydys commented 4 years ago

Ok. I will put in a ticket with that creator and see what they say. Otherwise I will just work around it. Thank you for your time.

On Wed, Jul 1, 2020 at 9:01 AM Skye Im notifications@github.com wrote:

If Piped Output has been updating, then it might be some kind of API mismatch. After all, Piped Output doesn't have any built in ways to allow other mods to hook into it, so I had to touch internals. If they changed how the mod works then Carbon Rev breaks.

On Wed, Jul 1, 2020, 15:54 jaydys notifications@github.com wrote:

Ok. Just ran a test on this to try and figure it out. And I just want to say that I only continue this because it seems like you want to figure this out as well since you reopened the ticket.

  1. Disabled all mods but carbon rev.
  2. Started new game in sandbox mode.
  3. Tested Coal Gen. No problems. Ran fine whether on battery or smart battery with auto wires.
  4. Turned on Piped Output mod. Gen still running fine.
  5. Piped CO2 out of gen into a container, issue occurred. (Generator swaps between enabled and idle within a subsecond cycle.)

So it looks like an issue between the actual use of piped output and the carbon rev mod. Trying different settings on CR mod. Seems that the lower the settings in CR the less of a pause in the Gen and it is able to output power close to a normal rate. But the higher the settings in CR the longer the pause, therefore, the slower the power gen. Output of CO2 is 1kg/s at the gen and the vents are getting 200g/s. So maybe an issue with the output capabilities of the piped mod. Took a quick look at the .dll for piped mod and didn't find any limits on the output, but I am a total noob when it comes to this type of modding.

So this may be an issue to take up with the Piped Output creator.

On Sun, Jun 28, 2020 at 11:06 PM Jason Poyner jason.l.poyner@gmail.com wrote:

Open/Close state? On the generators? I haven't changed anything. I don't mess with files. And the only mod I can think of that affects the gens are piped output and maybe the more capacity mods that both work fine without the Carbon Rev installed. So if I am not messing with the states and the mods I have installed do not seem to be doing it, where would I turn next?

On Sun, Jun 28, 2020 at 1:24 PM Skye Im notifications@github.com wrote:

Reopened #41 https://github.com/skairunner/sky-oni-mods/issues/41.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/skairunner/sky-oni-mods/issues/41#event-3490559515 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AK3LHRXNARERIANLVD6OGYTRY6DFXANCNFSM4OKTBKAA

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/skairunner/sky-oni-mods/issues/41#issuecomment-652432909 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA22VO62653IDUB7RPOBHDLRZM52VANCNFSM4OKTBKAA

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/skairunner/sky-oni-mods/issues/41#issuecomment-652436448, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK3LHRSTTBCMMUUZOP5MD5TRZM6RXANCNFSM4OKTBKAA .