codecov[bot]
commented
4 years ago Codecov Report
Merging #29 into master will increase coverage by
0.17%. The diff coverage is84.61%.
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 78.50% 78.68% +0.17%
==========================================
Files 14 14
Lines 1261 1243 -18
==========================================
- Hits 990 978 -12
+ Misses 271 265 -6 | Flag | Coverage Δ | |
|---|---|---|
| #unittests | 78.68% <84.61%> (+0.17%) |
:arrow_up: |
| Impacted Files | Coverage Δ | |
|---|---|---|
| fhirzeug/cli.py | 0.00% <0.00%> (ø) |
|
| fhirzeug/generator.py | 80.00% <ø> (ø) |
|
| fhirzeug/generators/python/settings.py | 0.00% <0.00%> (ø) |
|
| fhirzeug/generators/yaml_model.py | 100.00% <ø> (ø) |
|
| fhirzeug/logger.py | 17.64% <0.00%> (ø) |
|
| fhirzeug/fhirrenderer.py | 74.78% <55.55%> (-1.89%) |
:arrow_down: |
| fhirzeug/fhirspec.py | 84.92% <91.30%> (+0.66%) |
:arrow_up: |
| fhirzeug/fhirclass.py | 62.98% <100.00%> (+0.17%) |
:arrow_up: |
| fhirzeug/generators/default/mappings.py | 100.00% <100.00%> (ø) |
|
| fhirzeug/generators/default/settings.py | 100.00% <100.00%> (ø) |
|
| ... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update c2baedd...9f50285. Read the comment docs.
Wauplin
Close #23 . Add code quality check with Flake8, Black and Mypy tools. It required to change a lot of lines in the project. I think it's relevant to look more closely to what I've done even if the build checks pass.
Also I have a comment on how to configure Flake8 correctly. See comment below.