skalenetwork / filestorage

SKALE filestorage extension to EVM
GNU Affero General Public License v3.0
20 stars 3 forks source link

Emitting events in Filestorage #117

Open PolinaKiporenko opened 2 years ago

PolinaKiporenko commented 2 years ago

For File storage UI, we need to display file timestamps. Now there are difficulties with displaying time stamps in UI due to in the file storage contract we don’t save the time stamp field and don’t emit this event.

Solution: Emit event in all functions which modify the state: createFile createDirectory deleteFile ...

DmytroNazarenko commented 2 years ago

We can add timestamps to ContentInfo struct: https://github.com/skalenetwork/filestorage/blob/develop/contracts/FileStorage.sol#L44

gannakulikova commented 2 years ago

@cstrangedk @christineRPM @ebruoguzberk the question from @DmytroNazarenko is still pending and is blocking further implementation: should we save a timestamp in smart contracts? Thank you

cstrangedk commented 2 years ago

move to 2.2 release