search

skalenetwork / ima-js

JS/TS library for interacting with SKALE IMA Bridge
https://docs.skale.network/docs/
GNU Lesser General Public License v3.0
1 stars 3 forks source link

Error during yarn deploy-tokens: Error HH303: Unrecognized task erc20 #20

Closed tarasglek closed 2 years ago

tarasglek commented 2 years ago

I'm trying to follow the readme to run ima-js tests.

However command yarn deploy-tokens fails:

yarn deploy-tokens
yarn run v1.22.18
$ bash ./scripts/deploy_test_tokens.sh
./scripts/deploy_test_tokens.sh: line 9: [: ==: unary operator expected
Error HH303: Unrecognized task erc20

For more info go to https://hardhat.org/HH303 or run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Note adding INSTALL_PACKAGES variable results in same issue. I see this bash error a lot in skale bash scripts. It could be improved by adding double quotes, eg from 

if [ $INSTALL_PACKAGES == 'True' ]; then

to

if [ "$INSTALL_PACKAGES" == 'True' ]; then
tarasglek commented 2 years ago

Just realized from looking at the repo in github.com, those are git submodules. Would be good to add git clone instructions to readme, eg 

git clone --recurse-submodules --remote-submodules https://github.com/skalenetwork/ima-js
tarasglek commented 2 years ago

The following command yarn test needs package.json updated with yarn add mocha