skalenetwork / sgxwallet

sgxwallet is the first-ever opensource high-performance hardware secure crypto wallet that is based on Intel SGX technology. First opensource product on Intel SGX whitelist. Scales to 100,000+ transactions per second. Currently supports ETH and SKALE, and will support BTC in the future. Sgxwallet is under heavy development and use by SKALE network.
https://skale.network
GNU Affero General Public License v3.0
63 stars 33 forks source link

sgxwallet cannot sign message with 0x prefix #382

Closed sync-by-unito[bot] closed 2 years ago

sync-by-unito[bot] commented 2 years ago

sgxwallet cannot sign message with 0x prefix

┆Issue is synchronized with this Jira Bug

oleksandrSydorenkoJ commented 2 years ago

Verified https://skalelabs.atlassian.net/browse/SKALE-5007

sync-by-unito[bot] commented 2 years ago

➤ Oleksandr Sydorenko commented:

Verified on Skale_legacy network skalenetwork/sgxwallet_release:1.83.0-stable.1

steps to reproduce

  1. Sent to SGX BLSSignRsp signed request with messageHash that starts from 0x
  2. check response
  3. check SGX logs

SGX logs:

[2022-04-21 13:32:52.800] [debug] Received request via ZMQ server: {"type":"BLSSignReq","keyShareName":"BLS_KEY:SCHAIN_ID:13248663568063594987239453009123983558648306846446815439494518245605729553915:NODE_ID:9:DKG_ID:4","messageHash":"0x93b190ad44042e9dedc1e99d60680765df7d1cba933a8e30e1e027731c4356ca","n":16,"signerIndex":10,"t":11,"cert":"-----BEGIN CERTIFICATE-----\nMIIC2zCCAcMCAgETMA0GCSqGSIb3DQEBCwUAMBsxGTAXBgNVBAMMEFNHWENBQ2Vy\ndGlmaWNhdGUwHhcNMjExMTE4MTQyMjU2WhcNMzExMTE2MTQyMjU2WjBLMUkwRwYD\nVQQDDEBiYmExY2M5MjkyZjRmNDgwNDZlMjRkNjFkODU0N2EwMmM5ODhhNTE5MWMz\nNDc5YjAyOTRkNGMzYzk2Y2ZjOTU2MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB\nCgKCAQEApgtB4irRDXF4vz8FsaNAMxHotxcy2TOWZXPtxfcGCqD37wPA3slm978a\ng9+9rqtdYqCxLrcYKX29TV403Jc2spDIN1K+sqjOECJk1kDIkQcjraVg0dCjCO5e\nrwJakpGkcCccOn/4wxBHIS5ZdfF9cq3I+HAjXv+iV31ifU0uZrhhLChXSRfwZLDX\n++gIWNJrw+83axfwGKmZxVi1xz5yUDNeQdXKRKH13mAiRwBHVyJ+rza2B6d2j1Qw\nPSf2y39jrrG2DpS3FeJokVeSdnG/zd32DMv1p8/6UIR+obLlfdY6iAIHb6qW2RwB\nHDdiR3n/60SePex8/iQ4Aws1vMSNywIDAQABMA0GCSqGSIb3DQEBCwUAA4IBAQCt\nUL1AuL5D9rRDEKypWbDsQLZzJkPAnglfwulnmgeFQT7eG1nXeYty67XcLH4aAOzC\nJrAM7QLx8s3pC+Er+n4wqPZTcxPtUb7d3aeZllK+NKWZ8dwpIgwDgq3LM3tfgAGT\nu8sXpEhVf/+RsByFVViBIxEzYvG5QFyGyxX8YW5P3YGZjOZnXnKBvbQffjeaIoHV\niNSD1XYC1U5Tr7eGGGy6C5JvLMwxpUmyokF8Ha6XDbXW4oXCMp9TS45yoNkyYPEO\n7w4Xn9nrsMHkF7iA9IpEmmqXjA7uuSdddIk2oJjilhg6gYxePv+rnDghGIYfED2D\nLu53GcPou5q9geP8hEVR\n-----END CERTIFICATE-----\n","msgSig":"4c16a6afa25fbb0492dd6421acdc455fa8738ca007991f63fda1ace75a1847fc5f0dd808de561eb2484897db051aef032b52d1d6dc9c7184b34c4d65b9cbef96987ecb7682a72c6622f7e62548523b03b615e9fb58c75075f610e8dd62150f0242055084efb83d76f0eeff8688e605bda7a2d6cbedf49043cdca2dafa30170e5b2e12fc5a67a51fd1606ac00523d7fac0946888865697a9422f8ae5fdf95f52017c5d028dfe049be019d25656bd2f053948010c6e1055cb6527e0dc8d5c63ce3f1d9e73824980daf37c033eecdd6582ff1e866cbb3494fa6c2bc45e5d15eb6119564e8852ed45a1c0341a9bc8853a239803a34682d886061b5291c034f13572e"} ENCLAVE_LOG:trustedEcdsaSign [2022-04-21 13:32:52.803] [debug] Send response to client: {"errorMessage":"","signature_r":"0x41eec41b0867e30019f888fab6513064de9b2c9cfb0ec980517cc62c94528139","signature_s":"0x4b03703f072f9cbf5358a919cea8c8ca8d27918fec20508c931c1ac7c7afe71f","signature_v":"1","status":0,"type":"ECDSASignRsp"} ENCLAVE_LOG:trustedEcdsaSign ENCLAVE_LOG:SGX call completed ENCLAVE_LOG:trustedGetPublicEcdsaKey

ENCLAVE_LOG:trustedEcdsaSign ENCLAVE_LOG:trustedEcdsaSign ENCLAVE_LOG:SGX call completed ENCLAVE_LOG:trustedGetPublicEcdsaKey [2022-04-21 13:32:54.068] [debug] Send response to client: {"errorMessage":"","signatureShare":"12889909100763660700104752862628260128244409145488147326257119222262165540516:16996136859551217074067788990988311564884674149971652150625575891116055298935:18910847184918813068302839855878895042146631207446723093735781925171957522212:1","status":0,"type":"BLSSignRsp"}console output:

signed_messgae: 4c16a6afa25fbb0492dd6421acdc455fa8738ca007991f63fda1ace75a1847fc5f0dd808de561eb2484897db051aef032b52d1d6dc9c7184b34c4d65b9cbef96987ecb7682a72c6622f7e62548523b03b615e9fb58c75075f610e8dd62150f0242055084efb83d76f0eeff8688e605bda7a2d6cbedf49043cdca2dafa30170e5b2e12fc5a67a51fd1606ac00523d7fac0946888865697a9422f8ae5fdf95f52017c5d028dfe049be019d25656bd2f053948010c6e1055cb6527e0dc8d5c63ce3f1d9e73824980daf37c033eecdd6582ff1e866cbb3494fa6c2bc45e5d15eb6119564e8852ed45a1c0341a9bc8853a239803a34682d886061b5291c034f13572e

RESPONSE {"errorMessage":"","signatureShare":"12889909100763660700104752862628260128244409145488147326257119222262165540516:16996136859551217074067788990988311564884674149971652150625575891116055298935:18910847184918813068302839855878895042146631207446723093735781925171957522212:1","status":0,"type":"BLSSignRsp"}