skalenetwork / skale-consensus

Running the very core of SKL network, SKALE BFT consensus is universal, modern, modular, high-performance, asynchronous, provably-secure, agent-based Proof-of-Stake blockchain consensus engine in C++ 17. Includes provably secure embedded Oracle. Used by SKALE elastic blockchains. Easy and flexible enough to implement your own blockchain or smart contract platform. BLS signatures and Binary Asynchronous Consensus are main building blocks.
https://docs.skale.network/technology/consensus-spec
GNU Affero General Public License v3.0
78 stars 32 forks source link

Beta #749

Closed kladkogex closed 1 year ago

guardrails[bot] commented 1 year ago

:warning: We detected 3 security issues in this pull request:

Insecure Network Communication (1)
Severity | Details | Docs :-: | :-- | :-: High | Title: **Weak SSL/TLS protocol**
https://github.com/skalenetwork/skale-consensus/blob/3bfbb97e8da45a53fbf41cdecfabceb47bb6caa4/oracle/OracleServerAgent.cpp#L275 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_network_communication.html?utm_source=ghpr#c.libcurl.weak-SSL-TLS-protocol) More info on how to fix Insecure Network Communication in [C/C++](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_network_communication.html?utm_source=ghpr). ---
Insecure Processing of Data (2)
Severity | Details | Docs :-: | :-- | :-: Medium | Title: **Unchecked return value for malloc family**
https://github.com/skalenetwork/skale-consensus/blob/3bfbb97e8da45a53fbf41cdecfabceb47bb6caa4/oracle/OracleServerAgent.cpp#L194 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr#c.lang.unchecked-ret-malloc-family) Medium | Title: **Unchecked return value for malloc family**
https://github.com/skalenetwork/skale-consensus/blob/3bfbb97e8da45a53fbf41cdecfabceb47bb6caa4/oracle/OracleServerAgent.cpp#L247 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr#c.lang.unchecked-ret-malloc-family) More info on how to fix Insecure Processing of Data in [C/C++](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.