skalenetwork / skale-consensus

Running the very core of SKL network, SKALE BFT consensus is universal, modern, modular, high-performance, asynchronous, provably-secure, agent-based Proof-of-Stake blockchain consensus engine in C++ 17. Includes provably secure embedded Oracle. Used by SKALE elastic blockchains. Easy and flexible enough to implement your own blockchain or smart contract platform. BLS signatures and Binary Asynchronous Consensus are main building blocks.
https://docs.skale.network/technology/consensus-spec
GNU Affero General Public License v3.0
78 stars 32 forks source link

Oracle code quality review #766

Closed kladkogex closed 1 year ago

kladkogex commented 1 year ago

Describe the bug

Oracle code quality review - review Oracle code, clean it, check that all error conditions and exceptions are handled, clean logs.

To Reproduce Steps to reproduce the behavior:

  1. Run ...
  2. See error

Code review

Expected behavior A clear and concise description of what you expected to happen.

Code has high quality, do not have unhandled exceptions and errors

Environment:

Ubuntu 20.04

Additional context Add any other context about the problem here, such as logs or source code. Please link to a GitHub Gist instead of posting any lengthy content.

None