skalenetwork / skale-consensus

Running the very core of SKL network, SKALE BFT consensus is universal, modern, modular, high-performance, asynchronous, provably-secure, agent-based Proof-of-Stake blockchain consensus engine in C++ 17. Includes provably secure embedded Oracle. Used by SKALE elastic blockchains. Easy and flexible enough to implement your own blockchain or smart contract platform. BLS signatures and Binary Asynchronous Consensus are main building blocks.
https://docs.skale.network/technology/consensus-spec
GNU Affero General Public License v3.0
78 stars 32 forks source link

Fast forward beta to develop #818

Closed kladkogex closed 10 months ago

guardrails[bot] commented 10 months ago

:warning: We detected 8 security issues in this pull request:

Hard-Coded Secrets (1)
Severity | Details | Docs :-: | :-- | :-: Medium | Title: **Hex High Entropy String**
https://github.com/skalenetwork/skale-consensus/blob/5a9b85d8f171e1ba5f7dfe244cff70e0e39aa5f4/json/JSONFactory.cpp#L483 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/general/hard-coded_secrets.html?utm_source=ghpr#HexHighEntropyString) More info on how to fix Hard-Coded Secrets in [General](https://docs.guardrails.io/docs/en/vulnerabilities/general/hard-coded_secrets.html?utm_source=ghpr). ---
Insecure Processing of Data (7)
Severity | Details | Docs :-: | :-- | :-: Medium | Title: **Pointer subtraction**
https://github.com/skalenetwork/skale-consensus/blob/5a9b85d8f171e1ba5f7dfe244cff70e0e39aa5f4/miniz.c#L1331 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr#c.lang.pointer-subtraction) Medium | Title: **Pointer subtraction**
https://github.com/skalenetwork/skale-consensus/blob/5a9b85d8f171e1ba5f7dfe244cff70e0e39aa5f4/miniz.c#L2272 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr#c.lang.pointer-subtraction) Medium | Title: **Pointer subtraction**
https://github.com/skalenetwork/skale-consensus/blob/5a9b85d8f171e1ba5f7dfe244cff70e0e39aa5f4/miniz.c#L2339 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr#c.lang.pointer-subtraction) Medium | Title: **Pointer subtraction**
https://github.com/skalenetwork/skale-consensus/blob/5a9b85d8f171e1ba5f7dfe244cff70e0e39aa5f4/miniz.c#L2340 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr#c.lang.pointer-subtraction) Medium | Title: **Pointer subtraction**
https://github.com/skalenetwork/skale-consensus/blob/5a9b85d8f171e1ba5f7dfe244cff70e0e39aa5f4/miniz.c#L2462 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr#c.lang.pointer-subtraction) Medium | Title: **Pointer subtraction**
https://github.com/skalenetwork/skale-consensus/blob/5a9b85d8f171e1ba5f7dfe244cff70e0e39aa5f4/miniz.c#L2463 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr#c.lang.pointer-subtraction) High | Title: **NULL Pointer Dereference**
https://github.com/skalenetwork/skale-consensus/blob/5a9b85d8f171e1ba5f7dfe244cff70e0e39aa5f4/crypto/CryptoManager.cpp#L400 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr#c.lang.null-ptr-deref) More info on how to fix Insecure Processing of Data in [C/C++](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.