search

skalenetwork / skale-manager

Ethereum Mainnet smart contracts that manage SKALE Network. Coordinates validator-node registration, SKALE Chain creation, bounties, delegation, distributed key generation and service level agreements
GNU Affero General Public License v3.0
55 stars 30 forks source link

Add ability to pass erector address durion schain creation #689

Closed sync-by-unito[bot] closed 2 years ago

sync-by-unito[bot] commented 3 years ago

As a fallback option Marionette is controlled not only with IMA but also with MultiSigWallet predeployed on schain. During schain creation schain owner provides erector key that is set as the only MultiSigWallet owner. After schain creation it’s an schain owner responsibility to neither add more addresses to it or completely disable.

┆Issue is synchronized with this Jira Task

sync-by-unito[bot] commented 2 years ago

➤ Automation for Jira commented:

Corresponding Pull Request https://github.com/skalenetwork/skale-manager/pull/706

sync-by-unito[bot] commented 2 years ago

➤ Oleksandr Salamatov commented:

Verified manager: 1.8.2-develop.43 ( https://github.com/skalenetwork/skale-manager/releases/tag/1.8.2-develop.43 ) Schain created after manager update: 0xC1E411F617485E59FA5A795982AEC684BF84A0F1BE429D35886DD75A57C2AC6A Correct SchainErector (0x1026467C91fdA40aCc7e6935d1E52f67274FD669)

Schain created before manager update: 0x2F4C931380BAAECF90F865F2A904772E2122A66318BA6DE8CE7667C07EB71F2D Correct SchainErector(0x0000000000000000000000000000000000000000)

Also when we create SChain and set in SchainOwner field that is not contract, SchainErector is automatically sets to 0x0000000000000000000000000000000000000000, like in 0xC6ACD30BF46A4F30538EFA33126EFE597F3AC4DD2D487C778634B499D0D84C75 case, AddSchain tx hash https://rinkeby.etherscan.io/tx/0x8969e39fd7d7518ad8488b2f672810a2476c26abc0a1f2b1fbdc02a8a6ea52b4 ( https://rinkeby.etherscan.io/tx/0x8969e39fd7d7518ad8488b2f672810a2476c26abc0a1f2b1fbdc02a8a6ea52b4 )

sync-by-unito[bot] commented 2 years ago

➤ Automation for Jira commented:

Corresponding Pull Request https://github.com/skalenetwork/skale-manager/pull/707