skalnik / aqi-wtf

😷 WTF is the AQI near me right now?!
https://aqi.wtf
MIT License
44 stars 12 forks source link

More iOS Styling #49

Closed skalnik closed 4 years ago

skalnik commented 4 years ago

A new round of iOS styling work that fixes a handful of problems and adds some improvements. Changes include:

Have some screen shots!

Screen Shot 2020-09-09 at 11 28 47 PM Screen Shot 2020-09-09 at 11 28 36 PM Screen Shot 2020-09-09 at 11 30 14 PM Screen Shot 2020-09-09 at 11 30 17 PM Screen Shot 2020-09-09 at 11 30 51 PM
vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/7lm3k18oa
✅ Preview: https://aqi-wtf-git-more-ios-styling-work.skalnik.vercel.app

skalnik commented 4 years ago

Oh no, look like we got some footer overlap with the main text on my iPhone XS!

IMG_5643

skalnik commented 4 years ago

Used even more flex box and resolved that!

IMG_5644

skalnik commented 4 years ago

I wonder if I can fix the landscape scroll in that last comment by eliminating some upper padding. Also, this is useful for maybe making the notch look a bit better https://dev.to/oskarlarsson/designing-native-like-progressive-web-apps-for-ios-510o

skalnik commented 4 years ago

I wonder if I can fix the landscape scroll in that last comment by eliminating some upper padding.

Looking now, I don't think that will be reasonable. But that's ok, the layout is fine! Fixing the notch stuff will be nice, so I'll make that happen and then merge this.

skalnik commented 4 years ago

Fixing the notch stuff will be nice, so I'll make that happen and then merge this.

JK "black translucent" means that the status bar is unreadable if you get an error so I guess we'll leave it as is.