skalnik / aqi-wtf

😷 WTF is the AQI near me right now?!
https://aqi.wtf
MIT License
44 stars 12 forks source link

Make the AQI number gigantic #52

Closed obra closed 4 years ago

obra commented 4 years ago

Along the way, add a link to an explanation of what kinds of AQI corrections exist and which one we're using.

Also fixes a bug where we wouldn't clear the previous body class when refreshing the page.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/dsuyhy5ms
✅ Preview: https://aqi-wtf-git-fork-obra-calculation-type.skalnik.vercel.app

obra commented 4 years ago

old: image

new image

obra commented 4 years ago

@skalnik If you're around, what's your take on these two PRs - I've got other work I'm procrastinating and would be happy to keep iterating :)

skalnik commented 4 years ago

@obra I'm checking this one out right now and fixing up some styling! 😅 Sorry for the delay

obra commented 4 years ago

On Fri, Sep 11, 2020, at 7:35 PM, Mike Skalnik wrote:

@obra https://github.com/obra I'm checking this one out right now and fixing up some styling! 😅 Sorry for the delay

Don't sweat it! I hope the dentist wasn't too traumatic.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skalnik/aqi-wtf/pull/52#issuecomment-691387409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2EOVG266CHJZUZHNB3SFLM63ANCNFSM4RGOTJGA.

skalnik commented 4 years ago

Overall this is great. I moved the sizing down a tad using em instead of vw so that it doesn't get super-sized when wide, since that lead to the emoji ending up blurry.

Before:

Screen Shot 2020-09-11 at 7 40 07 PM

After:

Screen Shot 2020-09-11 at 7 39 45 PM

And still remains about the same on iOS:

Screen Shot 2020-09-11 at 7 42 22 PM

I also fixed up the AQandU article link which was broken. I think it may change anytime they update the article? I wonder if we can find a stable URL for that.

obra commented 4 years ago

sob I thought we finally lived in the future where color emoji fonts were SVG.

skalnik commented 4 years ago

sob I thought we finally lived in the future where color emoji fonts were SVG.

Same 😞

obra commented 4 years ago

Hm. On my XS, it's now -too- big. Well, the emoji is on its own line. Which is fine for now, really. So yeah. LGTM

skalnik commented 4 years ago

Hm. On my XS, it's now -too- big. Well, the emoji is on its own line. Which is fine for now, really.

Ooh, interesting! I went ahead and made it pick the minimum between the 25vw along with the 10em size. Hopefully that fixes that.

obra commented 4 years ago

Yes. Confirmed fixed on my XS

On Fri, Sep 11, 2020, at 7:55 PM, Mike Skalnik wrote:

Hm. On my XS, it's now -too- big. Well, the emoji is on its own line. Which is fine for now, really.

Ooh, interesting! I went ahead and made it pick the minimum between the 25vw along with the 10em size. Hopefully that fixes that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skalnik/aqi-wtf/pull/52#issuecomment-691390767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2BPFGNA4PJU52N3HKLSFLPLNANCNFSM4RGOTJGA.