skalnik / aqi-wtf

😷 WTF is the AQI near me right now?!
https://aqi.wtf
MIT License
44 stars 12 forks source link

Switch to more actionable explanations of the air quality badness. #53

Closed obra closed 3 years ago

obra commented 3 years ago

These explanations from an EPA publication found at https://www.airnow.gov/sites/default/files/2019-02/air-quality-guide_pm_2015.pdf and are the most "actionable" version of the explanations.

Additionally, move the prose descriptions into the HTML and toggle them on and off with CSS. This cuts down the strings in the HTML, reduces the amount of manual DOM twiddling we need to do and reduces the chance that our various tables of the differing levels of badness will get out of sync.

I'm gonna stop messing around for now.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/mgweq72wn
✅ Preview: https://aqi-wtf-git-fork-obra-update-warnings.skalnik.vercel.app

skalnik commented 3 years ago

Additionally, move the prose descriptions into the HTML and toggle them on and off with CSS. This cuts down the strings in the HTML, reduces the amount of manual DOM twiddling we need to do and reduces the chance that our various tables of the differing levels of badness will get out of sync.

That's some good thinking! I'm heading to bed since I have an early dentist appt but I'll check these PRs out tomorrow.

obra commented 3 years ago

Oof...Sleep well. Hope it goes smoothly. If this technique works for you, I'll update the rest of the stuff to use the same style.

skalnik commented 3 years ago

This PR overall looks good. I think left justifying the descriptions mostly makes sense, but it also can look strange. I wonder if we should center some of the shorter ones. (Ignore the AQI # since I just manually changed the class to good)

Screen Shot 2020-09-11 at 7 36 21 PM
obra commented 3 years ago

What if instead we moved the descriptions to below the sensor information? I think that might look a bit nicer and would make the lack of centering possibly feel reasonable.

On Fri, Sep 11, 2020, at 7:37 PM, Mike Skalnik wrote:

This PR overall looks good. I think left justifying the descriptions mostly makes sense, but it also can look strange. I wonder if we should center some of the shorter ones. (Ignore the AQI # since I just manually changed the class to good)

Screen Shot 2020-09-11 at 7 36 21 PM https://user-images.githubusercontent.com/2546/92985309-328a7e00-f466-11ea-967d-3efebb30552f.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/skalnik/aqi-wtf/pull/53#issuecomment-691387802, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2GFBWEJTSVKHV2UZ23SFLNHFANCNFSM4RGRRDXQ.

skalnik commented 3 years ago

What if instead we moved the descriptions to below the sensor information? I think that might look a bit nicer and would make the lack of centering possibly feel reasonable.

Seems reasonable to try!

obra commented 3 years ago
Screen Shot 2020-09-11 at 8 05 16 PM Screen Shot 2020-09-11 at 8 05 04 PM

Later, it may be time to play with font sizes some more. (possibly dropping the sensor link font size)

skalnik commented 3 years ago

I dig it 👍