Closed skalnik closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/fpyjsai0g
✅ Preview: https://aqi-wtf-git-small-container-margin.skalnik.vercel.app
I simplified the footer too. I figure we already have links to PurpleAir and GitHub, so we don't need additional ones, but perhaps that's too hasty?
100% agree on the padding. Thanks for beating me to it. I feel like we do want explicit links to GitHub and PurpleAir.
Cool, I went ahead and re-added those links.
I also did some small markup changes:
<b>
with <strong>
. Functionally they're the same, but <strong>
is preferred since it denotes "strong emphasis" over b
which just denotes "bold" and HTML isn't supposed to specifically denote appearance. How much this actually matters in use, I'm unsure, but it's the better practice from my understandingHow about
(Sorry, was off prototyping. I hear you on my horrible gen-x html use of instead of strong ;) Keep hassling me if I keep doing it.
I like that! Seems both shorter but retains all the link!
Made with ❤️ by <a href="https://skalnik.com">@skalnik</a> & <a href="https://github.com/skalnik/aqi-wtf/graphs/contributors">friends</a> • <a href="https://github.com/skalnik/aqi-wtf/">Code</a> • <a href="https://purpleair.com">Data</a> • <a href="/privacy.html">Privacy</a>
I'm always happy to keep hassling, but I gotta notice and remember myself!
Looks great.
Style updates are nonstop. I added a small amount of
padding
on the main container so that the new descriptors don't hit the edges.Before:
After: