search

skalyan91 / south-up

Code and data for generating a Pacific-centred map with south facing up.
3 stars 1 forks source link

Have shading match orientation #7

Closed skalyan91 closed 1 year ago

skalyan91 commented 1 year ago

@HedvigS I notice you’ve added an option that controls whether south is up or down. The thing is, the shading currently assumes that south is up (and the light source is in the south-east). If you want to produce a south-down map, then the shading should be such that the light source is in the north-west.

Want to try fixing this? Or if it isn’t the sort of thing that bothers you, then I’ll do it.

HedvigS commented 1 year ago

yes I mainly focussed on the flat one because it seemed easier.

The shading direction wasn't something I had thought about, feel free to roll that into the options

skalyan91 commented 1 year ago

Fixed in https://github.com/skalyan91/south-up/commit/90da92d4d10701b105e2770dbd4dd921bae2eb37 (though the .qs files may have to be sliced into smaller chunks).