search

skanaar / nomnoml

The sassy UML diagram renderer
https://www.nomnoml.com
MIT License
2.66k stars 208 forks source link

Docker Support #143

Closed soulteary closed 3 years ago

soulteary commented 3 years ago

It is a good tool, and perhaps more people should use it.

I wrote a simple docker file for it and created a base image, allows more people to run only one nginx mirror to use 90% of nomnoml functions.

If you think docker is a good part of this project, I am happy to continue adding server-side API mirroring for it.

usage:

docker run --rm -it -p 8080:80 soulteary/nomnoml

open browser: localhost:8080

skanaar commented 3 years ago

I don't use Docker myself so I am worried that this feature would not get the testing and maintenance that the users would expect.

Two questions:

soulteary commented 3 years ago
  • What problems is Docker support solving here?

Just like other widely used open source software, docker can simplify deployment and distribution. And even server-side rendering (nomnoml api) can be done without Node.js runtime. I will provide a demo and a detailed article later : )

  • The Dockerfile does not seem to rely on anything else within the repo. Perhaps this file could reside in a separate repo?

I agree with you, but there seems to be no project group named nomnoml at the moment, so I submit PR here.

soulteary commented 3 years ago

Hi, I've created a new project, does not include any software other than nginx and nomnoml, so that the resource usage is very small and the performance is high enough.

Should I resubmit a pr? Do you have any advice? @skanaar

skanaar commented 3 years ago

Nice to have an entry in hub.docker.com for this 👍 There are several examples of Nomnoml utilities that are hosted by their authors (React and angular components, VS Code plugins etc) and this looks like a great way of publishing the Docker Nomnoml project. (is it called "image"?)

I am happy with you, soulteary, being the host of the plugin. If and when Nomnoml get it's own github project and the Docker image is popular we can host it under the Nomnoml umbrella.

I will close this PR, but you are welcome to start a GitHub discussions thread about in the Nomnoml project so people can give feedback on the feature.

soulteary commented 3 years ago

I look forward to this project getting better and better.

Thank you for your hard work.