search

skanaar / nomnoml

The sassy UML diagram renderer
https://www.nomnoml.com
MIT License
2.66k stars 208 forks source link

Fix issue #170 #171

Closed TTWNO closed 2 years ago

TTWNO commented 2 years ago

Fixes the issue where the composition diamond isn't filled in when exporting to SVG.

Seems to work now. Composition diamond is now filled; aggregation diamond is unfilled (as it should be).

TTWNO commented 2 years ago

Ok, this doesn't work. Sorry. It was working, then stopped all of a sudden.... I'll send a new comment once it works.

TTWNO commented 2 years ago

Alright, that one seems to work. I'm not entirely sure how g.restore() works, but the way it's written seems to work for my use case so far.

skanaar commented 2 years ago

save and restore should always come in pairs, they open and close <g> SVG tag pairs.

I'll have a look tomorrow.